From ca4ea87d37b2f573c24de26d54f0225ed1394d48 Mon Sep 17 00:00:00 2001
From: kovakmedya <egecankomur@gmail.com>
Date: Thu, 21 May 2026 23:01:52 +0300
Subject: [PATCH] feat(patients): drop phone/dateOfBirth, name fields optional
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reduced the patient record to the minimum a dental clinic actually needs:
just a code, optional first/last name and free-text notes. Phone and
date-of-birth fields are gone from the UI everywhere — Add form, edit
dialog inside the table, the Bağlantı Bilgileri block on job detail, and
the table column list. The patient list now surfaces 'Notlar' instead.

Backend
  - DB: firstName and lastName columns set to required=false via Appwrite
    MCP (tables_db_update_string_column). Existing rows untouched.
  - schema.ts Patient interface: firstName/lastName now optional, phone
    and dateOfBirth removed from the type entirely. The underlying columns
    are still in the DB so legacy rows aren't broken — we just stop
    referencing them in code.
  - validation/patient.ts: firstName/lastName drop min(1), phone and dob
    fields removed.
  - patient-actions.ts: pickFields no longer reads phone/dob, create and
    update payloads no longer write them.

UI fallbacks
  - PatientsTable: header has 'Notlar' instead of Telefon/Doğum. Ad Soyad
    cell shows the joined name or em-dash. Edit dialog mirrors the same
    simplified form.
  - jobs/[jobId] detail page: when patient row has neither name, the page
    title falls back to 'Hasta {patientCode}' (same as before for jobs
    without a linked patient). The Hasta Bilgileri card now shows Ad Soyad
    and Patient Code side by side, with notes spanning both columns.
---
 src/app/(dashboard)/jobs/[jobId]/page.tsx     | 20 ++++----
 .../patients/components/patient-form.tsx      | 26 ++--------
 .../patients/components/patients-table.tsx    | 47 ++++---------------
 src/lib/appwrite/patient-actions.ts           |  6 ---
 src/lib/appwrite/schema.ts                    |  6 +--
 src/lib/validation/patient.ts                 | 11 ++---
 6 files changed, 32 insertions(+), 84 deletions(-)

diff --git a/src/app/(dashboard)/jobs/[jobId]/page.tsx b/src/app/(dashboard)/jobs/[jobId]/page.tsx
index d7cd44c..717f838 100644
--- a/src/app/(dashboard)/jobs/[jobId]/page.tsx
+++ b/src/app/(dashboard)/jobs/[jobId]/page.tsx
@@ -100,10 +100,13 @@ export default async function JobDetailPage({
             {counterpartLabel}: {counterpart?.companyName ?? "—"}
           </p>
           <h1 className="text-2xl font-bold tracking-tight">
-            {patient ? `${patient.firstName} ${patient.lastName}` : `Hasta ${job.patientCode}`}
+            {(() => {
+              const name = [patient?.firstName, patient?.lastName].filter(Boolean).join(" ");
+              return name || `Hasta ${job.patientCode}`;
+            })()}
           </h1>
           <p className="text-muted-foreground text-sm">
-            {patient && (
+            {patient && (patient.firstName || patient.lastName) && (
               <>
                 <span className="font-mono">{job.patientCode}</span> ·{" "}
               </>
@@ -211,18 +214,15 @@ export default async function JobDetailPage({
               dışında bir veri görmez.
             </CardDescription>
           </CardHeader>
-          <CardContent className="grid gap-4 text-sm md:grid-cols-3">
+          <CardContent className="grid gap-4 text-sm md:grid-cols-2">
             <Info label="Ad Soyad">
-              {patient.firstName} {patient.lastName}
+              {[patient.firstName, patient.lastName].filter(Boolean).join(" ") || "—"}
             </Info>
-            <Info label="Telefon">{patient.phone || "—"}</Info>
-            <Info label="Doğum Tarihi">
-              {patient.dateOfBirth
-                ? dateFormatter.format(new Date(patient.dateOfBirth))
-                : "—"}
+            <Info label="Hasta Kodu">
+              <span className="font-mono">{patient.patientCode}</span>
             </Info>
             {patient.notes && (
-              <div className="md:col-span-3">
+              <div className="md:col-span-2">
                 <p className="text-muted-foreground mb-1 text-xs font-medium uppercase tracking-wide">
                   Notlar
                 </p>
diff --git a/src/app/(dashboard)/patients/components/patient-form.tsx b/src/app/(dashboard)/patients/components/patient-form.tsx
index 79ea77c..b08df4b 100644
--- a/src/app/(dashboard)/patients/components/patient-form.tsx
+++ b/src/app/(dashboard)/patients/components/patient-form.tsx
@@ -8,6 +8,7 @@ import { Button } from "@/components/ui/button";
 import { Input } from "@/components/ui/input";
 import { Label } from "@/components/ui/label";
 import { Textarea } from "@/components/ui/textarea";
+
 import { createPatientAction } from "@/lib/appwrite/patient-actions";
 import { initialPatientFormState } from "@/lib/appwrite/patient-types";
 
@@ -48,38 +49,21 @@ export function PatientForm() {
 
       <div className="grid grid-cols-2 gap-3">
         <div className="grid gap-2">
-          <Label htmlFor="firstName">Ad *</Label>
-          <Input id="firstName" name="firstName" required maxLength={100} />
+          <Label htmlFor="firstName">Ad</Label>
+          <Input id="firstName" name="firstName" maxLength={100} />
           {state.fieldErrors?.firstName && (
             <p className="text-destructive text-xs">{state.fieldErrors.firstName}</p>
           )}
         </div>
         <div className="grid gap-2">
-          <Label htmlFor="lastName">Soyad *</Label>
-          <Input id="lastName" name="lastName" required maxLength={100} />
+          <Label htmlFor="lastName">Soyad</Label>
+          <Input id="lastName" name="lastName" maxLength={100} />
           {state.fieldErrors?.lastName && (
             <p className="text-destructive text-xs">{state.fieldErrors.lastName}</p>
           )}
         </div>
       </div>
 
-      <div className="grid gap-2">
-        <Label htmlFor="phone">Telefon</Label>
-        <Input
-          id="phone"
-          name="phone"
-          type="tel"
-          maxLength={30}
-          placeholder="+90 555 123 45 67"
-          autoComplete="tel"
-        />
-      </div>
-
-      <div className="grid gap-2">
-        <Label htmlFor="dateOfBirth">Doğum Tarihi</Label>
-        <Input id="dateOfBirth" name="dateOfBirth" type="date" />
-      </div>
-
       <div className="grid gap-2">
         <Label htmlFor="notes">Notlar</Label>
         <Textarea
diff --git a/src/app/(dashboard)/patients/components/patients-table.tsx b/src/app/(dashboard)/patients/components/patients-table.tsx
index 7646d05..19ee04e 100644
--- a/src/app/(dashboard)/patients/components/patients-table.tsx
+++ b/src/app/(dashboard)/patients/components/patients-table.tsx
@@ -36,12 +36,6 @@ import {
 } from "@/lib/appwrite/patient-types";
 import type { Patient } from "@/lib/appwrite/schema";
 
-const dateFormatter = new Intl.DateTimeFormat("tr-TR", {
-  day: "2-digit",
-  month: "2-digit",
-  year: "numeric",
-});
-
 export function PatientsTable({ rows }: { rows: Patient[] }) {
   if (rows.length === 0) {
     return (
@@ -57,8 +51,7 @@ export function PatientsTable({ rows }: { rows: Patient[] }) {
         <TableRow>
           <TableHead>Kod</TableHead>
           <TableHead>Ad Soyad</TableHead>
-          <TableHead>Telefon</TableHead>
-          <TableHead>Doğum</TableHead>
+          <TableHead>Notlar</TableHead>
           <TableHead>Durum</TableHead>
           <TableHead className="text-right">İşlem</TableHead>
         </TableRow>
@@ -92,11 +85,12 @@ function PatientRow({ row }: { row: Patient }) {
     <TableRow className={row.archived ? "opacity-60" : ""}>
       <TableCell className="font-mono text-xs">{row.patientCode}</TableCell>
       <TableCell className="font-medium">
-        {row.firstName} {row.lastName}
+        {[row.firstName, row.lastName].filter(Boolean).join(" ") || (
+          <span className="text-muted-foreground">—</span>
+        )}
       </TableCell>
-      <TableCell className="text-muted-foreground">{row.phone || "—"}</TableCell>
-      <TableCell className="text-muted-foreground">
-        {row.dateOfBirth ? dateFormatter.format(new Date(row.dateOfBirth)) : "—"}
+      <TableCell className="text-muted-foreground max-w-[280px] truncate">
+        {row.notes || "—"}
       </TableCell>
       <TableCell>
         {row.archived ? (
@@ -170,45 +164,24 @@ function EditPatientDialog({
           <input type="hidden" name="patientCode" value={row.patientCode} />
           <div className="grid grid-cols-2 gap-3">
             <div className="grid gap-2">
-              <Label htmlFor={`first-${row.$id}`}>Ad *</Label>
+              <Label htmlFor={`first-${row.$id}`}>Ad</Label>
               <Input
                 id={`first-${row.$id}`}
                 name="firstName"
-                defaultValue={row.firstName}
-                required
+                defaultValue={row.firstName ?? ""}
                 maxLength={100}
               />
             </div>
             <div className="grid gap-2">
-              <Label htmlFor={`last-${row.$id}`}>Soyad *</Label>
+              <Label htmlFor={`last-${row.$id}`}>Soyad</Label>
               <Input
                 id={`last-${row.$id}`}
                 name="lastName"
-                defaultValue={row.lastName}
-                required
+                defaultValue={row.lastName ?? ""}
                 maxLength={100}
               />
             </div>
           </div>
-          <div className="grid gap-2">
-            <Label htmlFor={`phone-${row.$id}`}>Telefon</Label>
-            <Input
-              id={`phone-${row.$id}`}
-              name="phone"
-              type="tel"
-              defaultValue={row.phone ?? ""}
-              maxLength={30}
-            />
-          </div>
-          <div className="grid gap-2">
-            <Label htmlFor={`dob-${row.$id}`}>Doğum Tarihi</Label>
-            <Input
-              id={`dob-${row.$id}`}
-              name="dateOfBirth"
-              type="date"
-              defaultValue={row.dateOfBirth ? row.dateOfBirth.slice(0, 10) : ""}
-            />
-          </div>
           <div className="grid gap-2">
             <Label htmlFor={`notes-${row.$id}`}>Notlar</Label>
             <Textarea
diff --git a/src/lib/appwrite/patient-actions.ts b/src/lib/appwrite/patient-actions.ts
index a8225e0..d576ab6 100644
--- a/src/lib/appwrite/patient-actions.ts
+++ b/src/lib/appwrite/patient-actions.ts
@@ -37,8 +37,6 @@ function pickFields(formData: FormData) {
     patientCode: String(formData.get("patientCode") ?? "").trim(),
     firstName: String(formData.get("firstName") ?? "").trim(),
     lastName: String(formData.get("lastName") ?? "").trim(),
-    phone: String(formData.get("phone") ?? "").trim(),
-    dateOfBirth: String(formData.get("dateOfBirth") ?? "").trim(),
     notes: String(formData.get("notes") ?? "").trim(),
   };
 }
@@ -134,8 +132,6 @@ export async function createPatientAction(
         patientCode: code,
         firstName: parsed.data.firstName,
         lastName: parsed.data.lastName,
-        phone: parsed.data.phone,
-        dateOfBirth: parsed.data.dateOfBirth,
         notes: parsed.data.notes,
         archived: false,
       },
@@ -193,8 +189,6 @@ export async function updatePatientAction(
     await tablesDB.updateRow(DATABASE_ID, TABLES.patients, id, {
       firstName: parsed.data.firstName,
       lastName: parsed.data.lastName,
-      phone: parsed.data.phone,
-      dateOfBirth: parsed.data.dateOfBirth,
       notes: parsed.data.notes,
     });
     await logAudit({
diff --git a/src/lib/appwrite/schema.ts b/src/lib/appwrite/schema.ts
index 1ad33b8..638f449 100644
--- a/src/lib/appwrite/schema.ts
+++ b/src/lib/appwrite/schema.ts
@@ -87,10 +87,8 @@ export interface Patient extends Row {
   clinicTenantId: string;
   createdBy: string;
   patientCode: string;
-  firstName: string;
-  lastName: string;
-  phone?: string;
-  dateOfBirth?: string;
+  firstName?: string;
+  lastName?: string;
   notes?: string;
   archived?: boolean;
 }
diff --git a/src/lib/validation/patient.ts b/src/lib/validation/patient.ts
index c449bce..1046fec 100644
--- a/src/lib/validation/patient.ts
+++ b/src/lib/validation/patient.ts
@@ -7,19 +7,18 @@ export const patientSchema = z.object({
     .max(50)
     .optional()
     .transform((v) => (v ? v.toUpperCase() : undefined)),
-  firstName: z.string().trim().min(1, "Ad zorunlu.").max(100),
-  lastName: z.string().trim().min(1, "Soyad zorunlu.").max(100),
-  phone: z
+  firstName: z
     .string()
     .trim()
-    .max(30)
+    .max(100)
     .optional()
     .transform((v) => (v ? v : undefined)),
-  dateOfBirth: z
+  lastName: z
     .string()
     .trim()
+    .max(100)
     .optional()
-    .transform((v) => (v ? new Date(v).toISOString() : undefined)),
+    .transform((v) => (v ? v : undefined)),
   notes: z
     .string()
     .trim()